[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240824140221.GM2164@kernel.org>
Date: Sat, 24 Aug 2024 15:02:21 +0100
From: Simon Horman <horms@...nel.org>
To: Pawel Dembicki <paweldembicki@...il.com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
Florian Fainelli <f.fainelli@...il.com>,
Vladimir Oltean <olteanv@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Russell King <linux@...linux.org.uk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: dsa: vsc73xx: implement FDB operations
On Thu, Aug 22, 2024 at 04:23:44PM +0200, Pawel Dembicki wrote:
> This commit introduces implementations of three functions:
> .port_fdb_dump
> .port_fdb_add
> .port_fdb_del
>
> The FDB database organization is the same as in other old Vitesse chips:
> It has 2048 rows and 4 columns (buckets). The row index is calculated by
> the hash function 'vsc73xx_calc_hash' and the FDB entry must be placed
> exactly into row[hash]. The chip selects the bucket number by itself.
>
> Signed-off-by: Pawel Dembicki <paweldembicki@...il.com>
>
> ---
> Changes in v2:
> - Use FIELD_PREP and macros in 'vsc73xx_calc_hash' funcion
Thanks for the update, that part now looks good to me.
I'll leave a proper review to others.
> - improve commit message
> - consolidate row, entry, bucket terminology
> - check for error codes from vsc73xx_read() and vsc73xx_write()
> - check if cr return error
> - remove redundant comment
> - set fdb_isolation flag
...
Powered by blists - more mailing lists