[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240824180316.GP2164@kernel.org>
Date: Sat, 24 Aug 2024 19:03:16 +0100
From: Simon Horman <horms@...nel.org>
To: Li Zetao <lizetao1@...wei.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, marcel@...tmann.org, johan.hedberg@...il.com,
luiz.dentz@...il.com, idryomov@...il.com, xiubli@...hat.com,
dsahern@...nel.org, trondmy@...nel.org, anna@...nel.org,
chuck.lever@...cle.com, jlayton@...nel.org, neilb@...e.de,
okorniev@...hat.com, Dai.Ngo@...cle.com, tom@...pey.com,
jmaloy@...hat.com, ying.xue@...driver.com, linux@...blig.org,
jacob.e.keller@...el.com, willemb@...gle.com, kuniyu@...zon.com,
wuyun.abel@...edance.com, quic_abchauha@...cinc.com,
gouhao@...ontech.com, netdev@...r.kernel.org,
linux-bluetooth@...r.kernel.org, ceph-devel@...r.kernel.org,
linux-nfs@...r.kernel.org, tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net-next 7/8] tipc: use min() to simplify the code
On Thu, Aug 22, 2024 at 09:39:07PM +0800, Li Zetao wrote:
> When calculating size of own domain based on number of peers, the result
> should be less than MAX_MON_DOMAIN, so using min() here is very semantic.
>
> Signed-off-by: Li Zetao <lizetao1@...wei.com>
> ---
> net/tipc/monitor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/tipc/monitor.c b/net/tipc/monitor.c
> index 77a3d016cade..e2f19627e43d 100644
> --- a/net/tipc/monitor.c
> +++ b/net/tipc/monitor.c
> @@ -149,7 +149,7 @@ static int dom_size(int peers)
>
> while ((i * i) < peers)
> i++;
> - return i < MAX_MON_DOMAIN ? i : MAX_MON_DOMAIN;
> + return min(i, MAX_MON_DOMAIN);
> }
Perhaps this whole function is open coding something, but
if so I couldn't find it.
In any case this looks safe to me as i is an unsigned int
while MAX_MON_DOMAIN is 64 (also an unsigned int, I believe).
And the code being replaced appears to be a min() operation
in both form and function.
Reviewed-by: Simon Horman <horms@...nel.org>
>
> static void map_set(u64 *up_map, int i, unsigned int v)
> --
> 2.34.1
>
>
Powered by blists - more mailing lists