netdev - Re: [PATCH net-next 2/8] Bluetooth: use min() to simplify the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240824181511.GS2164@kernel.org>
Date: Sat, 24 Aug 2024 19:15:11 +0100
From: Simon Horman <horms@...nel.org>
To: Li Zetao <lizetao1@...wei.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, marcel@...tmann.org, johan.hedberg@...il.com,
	luiz.dentz@...il.com, idryomov@...il.com, xiubli@...hat.com,
	dsahern@...nel.org, trondmy@...nel.org, anna@...nel.org,
	chuck.lever@...cle.com, jlayton@...nel.org, neilb@...e.de,
	okorniev@...hat.com, Dai.Ngo@...cle.com, tom@...pey.com,
	jmaloy@...hat.com, ying.xue@...driver.com, linux@...blig.org,
	jacob.e.keller@...el.com, willemb@...gle.com, kuniyu@...zon.com,
	wuyun.abel@...edance.com, quic_abchauha@...cinc.com,
	gouhao@...ontech.com, netdev@...r.kernel.org,
	linux-bluetooth@...r.kernel.org, ceph-devel@...r.kernel.org,
	linux-nfs@...r.kernel.org, tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net-next 2/8] Bluetooth: use min() to simplify the code

On Thu, Aug 22, 2024 at 09:39:02PM +0800, Li Zetao wrote:
> When copying data from skb, it needs to determine the copy length.
> It is easier to understand using min() here.
> 
> Signed-off-by: Li Zetao <lizetao1@...wei.com>

However, I don't believe Bluetooth changes usually don't go through next-next.
So I think this either needs to be reposted or get an ack from
the maintainer (already CCed).

Luiz, perhaps you can offer some guidance here?

> ---
>  net/bluetooth/hidp/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
> index 707f229f896a..7bf24f2993ba 100644
> --- a/net/bluetooth/hidp/core.c
> +++ b/net/bluetooth/hidp/core.c
> @@ -294,7 +294,7 @@ static int hidp_get_raw_report(struct hid_device *hid,
>  
>  	skb = session->report_return;
>  	if (skb) {
> -		len = skb->len < count ? skb->len : count;
> +		len = min(skb->len, count);

I am slightly dubious about this check, given the different types involved.
Is using min_t appropriate (I don't know)?

>  		memcpy(data, skb->data, len);
>  
>  		kfree_skb(skb);
> -- 
> 2.34.1
> 
>