netdev - Re: [PATCH net-next 8/8] SUNRPC: use min() to simplify the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zsokv8+9aDoR4uOu@tissot.1015granger.net>
Date: Sat, 24 Aug 2024 14:21:51 -0400
From: Chuck Lever <chuck.lever@...cle.com>
To: Simon Horman <horms@...nel.org>
Cc: Li Zetao <lizetao1@...wei.com>, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, marcel@...tmann.org,
        johan.hedberg@...il.com, luiz.dentz@...il.com, idryomov@...il.com,
        xiubli@...hat.com, dsahern@...nel.org, trondmy@...nel.org,
        anna@...nel.org, jlayton@...nel.org, neilb@...e.de,
        okorniev@...hat.com, Dai.Ngo@...cle.com, tom@...pey.com,
        jmaloy@...hat.com, ying.xue@...driver.com, linux@...blig.org,
        jacob.e.keller@...el.com, willemb@...gle.com, kuniyu@...zon.com,
        wuyun.abel@...edance.com, quic_abchauha@...cinc.com,
        gouhao@...ontech.com, netdev@...r.kernel.org,
        linux-bluetooth@...r.kernel.org, ceph-devel@...r.kernel.org,
        linux-nfs@...r.kernel.org, tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net-next 8/8] SUNRPC: use min() to simplify the code

On Sat, Aug 24, 2024 at 07:07:50PM +0100, Simon Horman wrote:
> On Thu, Aug 22, 2024 at 09:39:08PM +0800, Li Zetao wrote:
> > When reading pages in xdr_read_pages, the number of XDR encoded bytes
> > should be less than the len of aligned pages, so using min() here is
> > very semantic.
> > 
> > Signed-off-by: Li Zetao <lizetao1@...wei.com>
> > ---
> >  net/sunrpc/xdr.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
> > index 62e07c330a66..6746e920dbbb 100644
> > --- a/net/sunrpc/xdr.c
> > +++ b/net/sunrpc/xdr.c
> > @@ -1602,7 +1602,7 @@ unsigned int xdr_read_pages(struct xdr_stream *xdr, unsigned int len)
> >  	end = xdr_stream_remaining(xdr) - pglen;
> >  
> >  	xdr_set_tail_base(xdr, base, end);
> > -	return len <= pglen ? len : pglen;
> > +	return min(len, pglen);
> 
> Both len and pglen are unsigned int, so this seems correct to me.
> 
> And the code being replaced does appear to be a min() operation in
> both form and function.
> 
> Reviewed-by: Simon Horman <horms@...nel.org>
> 
> However, I don't believe SUNRPC changes usually don't go through next-next.
> So I think this either needs to be reposted or get some acks from
> Chuck Lever (already CCed).
> 
> Chuck, perhaps you can offer some guidance here?
> 
> >  }
> >  EXPORT_SYMBOL_GPL(xdr_read_pages);
> >  
> > -- 
> > 2.34.1
> > 
> > 

Changes to net/sunrpc/ can go through Anna and Trond's NFS client
trees, through the NFSD tree, or via netdev, but they are typically
taken through the NFS-related trees.

Unless the submitter or the relevant maintainers prefer otherwise,
I don't see a problem with this one going through netdev. Let me
know otherwise.

Acked-by: Chuck Lever <chuck.lever@...cle.com>


-- 
Chuck Lever