[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240825191638.146748-1-xiyou.wangcong@gmail.com>
Date: Sun, 25 Aug 2024 12:16:38 -0700
From: Cong Wang <xiyou.wangcong@...il.com>
To: netdev@...r.kernel.org
Cc: Cong Wang <cong.wang@...edance.com>,
Andreas Schultz <aschultz@...p.net>,
Pablo Neira Ayuso <pablo@...filter.org>,
Harald Welte <laforge@...monks.org>
Subject: [Patch net] gtp: fix a potential NULL pointer dereference
From: Cong Wang <cong.wang@...edance.com>
When sockfd_lookup() fails, gtp_encap_enable_socket() returns a
NULL pointer, but its callers only check for error pointers thus miss
the NULL pointer case.
Fix it by returning an error pointer with the error code carried from
sockfd_lookup().
(I found this bug during code inspection.)
Fixes: 1e3a3abd8b28 ("gtp: make GTP sockets in gtp_newlink optional")
Cc: Andreas Schultz <aschultz@...p.net>
Cc: Pablo Neira Ayuso <pablo@...filter.org>
Cc: Harald Welte <laforge@...monks.org>
Signed-off-by: Cong Wang <cong.wang@...edance.com>
---
drivers/net/gtp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c
index 0696faf60013..2e94d10348cc 100644
--- a/drivers/net/gtp.c
+++ b/drivers/net/gtp.c
@@ -1653,7 +1653,7 @@ static struct sock *gtp_encap_enable_socket(int fd, int type,
sock = sockfd_lookup(fd, &err);
if (!sock) {
pr_debug("gtp socket fd=%d not found\n", fd);
- return NULL;
+ return ERR_PTR(err);
}
sk = sock->sk;
--
2.34.1
Powered by blists - more mailing lists