netdev - Re: [PATCH net-next 7/8] net/rxrpc: Use min() to simplify the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e81473b2-174a-4ca1-ad66-2da98a513fcf@huawei.com>
Date: Mon, 26 Aug 2024 09:41:17 +0800
From: Hongbo Li <lihongbo22@...wei.com>
To: David Howells <dhowells@...hat.com>
CC: <johannes@...solutions.net>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <allison.henderson@...cle.com>,
	<dsahern@...nel.org>, <pshelar@....org>, <linux-wireless@...r.kernel.org>,
	<netdev@...r.kernel.org>, <rds-devel@....oracle.com>, <dccp@...r.kernel.org>,
	<dev@...nvswitch.org>, <linux-afs@...ts.infradead.org>
Subject: Re: [PATCH net-next 7/8] net/rxrpc: Use min() to simplify the code



On 2024/8/24 20:06, David Howells wrote:
> Hongbo Li <lihongbo22@...wei.com> wrote:
> 
>> -	summary.ack_reason = (sp->ack.reason < RXRPC_ACK__INVALID ?
>> -			      sp->ack.reason : RXRPC_ACK__INVALID);
>> +	summary.ack_reason = min(sp->ack.reason, RXRPC_ACK__INVALID);
> 
> Can you use umin() rather than min(), please?
> I see reason is u8, may I use min_t(u8, sp->ack.reason, RXRPC_ACK__INVALID);

Thanks,
Hongbo

> Thanks,
> David
> 
>