[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240826140628.99849-1-djahchankoike@gmail.com>
Date: Mon, 26 Aug 2024 11:06:13 -0300
From: Diogo Jahchan Koike <djahchankoike@...il.com>
To: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Maxime Chevallier <maxime.chevallier@...tlin.com>,
Christophe Leroy <christophe.leroy@...roup.eu>
Cc: Diogo Jahchan Koike <djahchankoike@...il.com>,
syzbot+ec369e6d58e210135f71@...kaller.appspotmail.com,
netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [patch net-next v2] net: ethtool: fix unheld rtnl lock
ethnl_req_get_phydev should be called with rtnl lock held.
Reported-by: syzbot+ec369e6d58e210135f71@...kaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=ec369e6d58e210135f71
Fixes: 31748765bed3 ("net: ethtool: pse-pd: Target the command to the requested PHY")
Signed-off-by: Diogo Jahchan Koike <djahchankoike@...il.com>
---
net/ethtool/pse-pd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/ethtool/pse-pd.c b/net/ethtool/pse-pd.c
index 507cb21d6bf0..0cd298851ea1 100644
--- a/net/ethtool/pse-pd.c
+++ b/net/ethtool/pse-pd.c
@@ -227,8 +227,11 @@ ethnl_set_pse_validate(struct ethnl_req_info *req_info, struct genl_info *info)
struct nlattr **tb = info->attrs;
struct phy_device *phydev;
+ rtnl_lock();
phydev = ethnl_req_get_phydev(req_info, tb[ETHTOOL_A_PSE_HEADER],
info->extack);
+ rtnl_unlock();
+
if (IS_ERR_OR_NULL(phydev)) {
NL_SET_ERR_MSG(info->extack, "No PHY is attached");
return -EOPNOTSUPP;
--
2.43.0
Powered by blists - more mailing lists