netdev - Re: [RFC] Why is set_config not supported in mlx5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd8ad1d9-81a0-4155-abf5-627ef08afa9e@lunn.ch>
Date: Mon, 26 Aug 2024 16:24:50 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Dragos Tatulea <dtatulea@...dia.com>
Cc: Carlos Bilbao <cbilbao@...italocean.com>, eli@...lanox.com,
	mst@...hat.com, jasowang@...hat.com, xuanzhuo@...ux.alibaba.com,
	virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
	eperezma@...hat.com, sashal@...nel.org, yuehaibing@...wei.com,
	steven.sistare@...cle.com
Subject: Re: [RFC] Why is set_config not supported in mlx5_vnet?

On Mon, Aug 26, 2024 at 11:06:09AM +0200, Dragos Tatulea wrote:
> 
> 
> On 23.08.24 18:54, Carlos Bilbao wrote:
> > Hello,
> > 
> > I'm debugging my vDPA setup, and when using ioctl to retrieve the
> > configuration, I noticed that it's running in half duplex mode:
> > 
> > Configuration data (24 bytes):
> >   MAC address: (Mac address)
> >   Status: 0x0001
> >   Max virtqueue pairs: 8
> >   MTU: 1500
> >   Speed: 0 Mb
> >   Duplex: Half Duplex
> >   RSS max key size: 0
> >   RSS max indirection table length: 0
> >   Supported hash types: 0x00000000
> > 
> > I believe this might be contributing to the underperformance of vDPA.
> mlx5_vdpa vDPA devicess currently do not support the VIRTIO_NET_F_SPEED_DUPLEX
> feature which reports speed and duplex. You can check the state on the
> PF.

Then it should probably report DUPLEX_UNKNOWN.

The speed of 0 also suggests SPEED_UNKNOWN is not being returned. So
this just looks buggy in general.

     Andrew