[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f2d6345a8a684f62035108d74938ec0b2e162019.camel@redhat.com>
Date: Mon, 26 Aug 2024 17:52:00 +0200
From: Philipp Stanner <pstanner@...hat.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Andy Shevchenko <andy@...nel.org>, Jonathan Corbet <corbet@....net>,
Jens Axboe <axboe@...nel.dk>, Wu Hao <hao.wu@...el.com>, Tom Rix
<trix@...hat.com>, Moritz Fischer <mdf@...nel.org>, Xu Yilun
<yilun.xu@...el.com>, Linus Walleij <linus.walleij@...aro.org>, Bartosz
Golaszewski <brgl@...ev.pl>, "David S. Miller" <davem@...emloft.net>, Eric
Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
Abeni <pabeni@...hat.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>, Maxime Coquelin
<mcoquelin.stm32@...il.com>, Bjorn Helgaas <bhelgaas@...gle.com>, Alvaro
Karsz <alvaro.karsz@...id-run.com>, "Michael S. Tsirkin" <mst@...hat.com>,
Jason Wang <jasowang@...hat.com>, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
Eugenio Pérez <eperezma@...hat.com>, Richard Cochran
<richardcochran@...il.com>, Mark Brown <broonie@...nel.org>, David Lechner
<dlechner@...libre.com>, Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>, Damien Le Moal <dlemoal@...nel.org>,
Hannes Reinecke <hare@...e.de>, Chaitanya Kulkarni <kch@...dia.com>,
linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-block@...r.kernel.org, linux-fpga@...r.kernel.org,
linux-gpio@...r.kernel.org, netdev@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-pci@...r.kernel.org,
virtualization@...ts.linux.dev
Subject: Re: [PATCH v3 5/9] ethernet: cavium: Replace deprecated PCI
functions
On Mon, 2024-08-26 at 18:41 +0300, Andy Shevchenko wrote:
> On Mon, Aug 26, 2024 at 5:51 PM Philipp Stanner <pstanner@...hat.com>
> wrote:
> > On Thu, 2024-08-22 at 17:44 +0300, Andy Shevchenko wrote:
> > > On Thu, Aug 22, 2024 at 03:47:37PM +0200, Philipp Stanner wrote:
>
> ...
>
> > > > - err = pcim_iomap_regions(pdev, 1 << PCI_PTP_BAR_NO,
> > > > pci_name(pdev));
> > > > - if (err)
> > > > + clock->reg_base = pcim_iomap_region(pdev, PCI_PTP_BAR_NO,
> > > > pci_name(pdev));
> > > > + if (IS_ERR(clock->reg_base)) {
> > > > + err = PTR_ERR(clock->reg_base);
> > > > goto error_free;
> > > > -
> > > > - clock->reg_base = pcim_iomap_table(pdev)[PCI_PTP_BAR_NO];
> > > > + }
> > >
> > > Perhaps
> > >
> > > clock->reg_base = pcim_iomap_region(pdev, PCI_PTP_BAR_NO,
> > > pci_name(pdev));
> > > err = PTR_ERR_OR_ZERO(clock->reg_base);
> > > if (err)
> > > goto error_free;
> > >
> > > This will make your patch smaller and neater.
> > >
> > > P.S. Do you use --histogram diff algo when preparing patches?
> >
> > So far not.
> > Should one do that?
>
> Id doesn't alter your code, it's in addition to what I suggested, but
> as Linus shared that there is no reason to avoid using --histogram
> not
> only in Linux kernel, but in general as it produces more
> human-readable diff:s.
If the Boss says so, one can surely do that \o/
Though if it has 0 disadvantages I'd propose proposing to the git-devs
to make it the default.
P.
>
Powered by blists - more mailing lists