netdev - Re: [PATCH 07/13] LSM: Use lsmblob in security_current

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202408270512.9cZ78Eog-lkp@intel.com>
Date: Tue, 27 Aug 2024 05:24:01 +0800
From: kernel test robot <lkp@...el.com>
To: Casey Schaufler <casey@...aufler-ca.com>, paul@...l-moore.com,
	linux-security-module@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, jmorris@...ei.org, serge@...lyn.com,
	keescook@...omium.org, john.johansen@...onical.com,
	penguin-kernel@...ove.sakura.ne.jp, stephen.smalley.work@...il.com,
	linux-kernel@...r.kernel.org, mic@...ikod.net,
	linux-integrity@...r.kernel.org, linux-audit@...hat.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH 07/13] LSM: Use lsmblob in security_current_getsecid

Hi Casey,

kernel test robot noticed the following build warnings:

[auto build test WARNING on pcmoore-selinux/next]
[also build test WARNING on zohar-integrity/next-integrity linus/master pcmoore-audit/next v6.11-rc5 next-20240826]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Casey-Schaufler/LSM-Add-the-lsmblob-data-structure/20240826-170520
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git next
patch link:    https://lore.kernel.org/r/20240825190048.13289-8-casey%40schaufler-ca.com
patch subject: [PATCH 07/13] LSM: Use lsmblob in security_current_getsecid
config: arc-randconfig-001-20240827 (https://download.01.org/0day-ci/archive/20240827/202408270512.9cZ78Eog-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240827/202408270512.9cZ78Eog-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408270512.9cZ78Eog-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> security/smack/smack_lsm.c:2265: warning: Function parameter or struct member 'blob' not described in 'smack_task_getlsmblob_obj'
>> security/smack/smack_lsm.c:2265: warning: Excess function parameter 'secid' description in 'smack_task_getlsmblob_obj'


vim +2265 security/smack/smack_lsm.c

1fb057dcde11b35 Paul Moore      2021-02-19  2255  
1fb057dcde11b35 Paul Moore      2021-02-19  2256  /**
fd64f9693f6c226 Casey Schaufler 2024-08-25  2257   * smack_task_getlsmblob_obj - get the objective data of the task
1fb057dcde11b35 Paul Moore      2021-02-19  2258   * @p: the task
1fb057dcde11b35 Paul Moore      2021-02-19  2259   * @secid: where to put the result
1fb057dcde11b35 Paul Moore      2021-02-19  2260   *
1fb057dcde11b35 Paul Moore      2021-02-19  2261   * Sets the secid to contain a u32 version of the task's objective smack label.
e114e473771c848 Casey Schaufler 2008-02-04  2262   */
fd64f9693f6c226 Casey Schaufler 2024-08-25  2263  static void smack_task_getlsmblob_obj(struct task_struct *p,
fd64f9693f6c226 Casey Schaufler 2024-08-25  2264  				      struct lsmblob *blob)
e114e473771c848 Casey Schaufler 2008-02-04 @2265  {
1fb057dcde11b35 Paul Moore      2021-02-19  2266  	struct smack_known *skp = smk_of_task_struct_obj(p);
2f823ff8bec03a1 Casey Schaufler 2013-05-22  2267  
fd64f9693f6c226 Casey Schaufler 2024-08-25  2268  	blob->smack.skp = skp;
fd64f9693f6c226 Casey Schaufler 2024-08-25  2269  	/* scaffolding */
fd64f9693f6c226 Casey Schaufler 2024-08-25  2270  	blob->scaffold.secid = skp->smk_secid;
e114e473771c848 Casey Schaufler 2008-02-04  2271  }
e114e473771c848 Casey Schaufler 2008-02-04  2272  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki