netdev - Re: [PATCH V2] wifi: ath6kl: Replace ath6kl_usb_submit_ctrl_in with usb_control_msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87seurfr3r.fsf@kernel.org>
Date: Mon, 26 Aug 2024 14:42:00 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Edward Adam Davis <eadavis@...com>
Cc: gregkh@...uxfoundation.org,  linux-kernel@...r.kernel.org,
  linux-usb@...r.kernel.org,  linux-wireless@...r.kernel.org,
  netdev@...r.kernel.org,
  syzbot+92c6dd14aaa230be6855@...kaller.appspotmail.com,
  syzkaller-bugs@...glegroups.com
Subject: Re: [PATCH V2] wifi: ath6kl: Replace ath6kl_usb_submit_ctrl_in with
 usb_control_msg_recv

Edward Adam Davis <eadavis@...com> writes:

> ath6kl_usb_submit_ctrl_in() did not take into account the situation where
> the length of the data read from the device is not equal to the len, and
> such missing judgments will result in subsequent code using incorrect data.
>
> usb_control_msg_recv() handles the abnormal length of the returned data,
> so using it directly can fix this warning.
>
> Reported-by: syzbot+92c6dd14aaa230be6855@...kaller.appspotmail.com
> Signed-off-by: Edward Adam Davis <eadavis@...com>

Did you test this on real ath6kl hardware?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches