netdev - Re: [PATCH -next] af_packet: display drop field in packet_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240826171917.55444272@hermes.local>
Date: Mon, 26 Aug 2024 17:19:17 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Liu Mingrui <liumingrui@...wei.com>
Cc: <willemdebruijn.kernel@...il.com>, <davem@...emloft.net>,
 <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
 <netdev@...r.kernel.org>
Subject: Re: [PATCH -next] af_packet: display drop field in packet_seq_show

On Mon, 26 Aug 2024 09:26:25 +0000
Liu Mingrui <liumingrui@...wei.com> wrote:

> Display the dropped count of the packet, which could provide more
> information for debugging.
> 
> Signed-off-by: Liu Mingrui <liumingrui@...wei.com>
> ---

At this point /proc/net/packet is a poor choice for extension.
For example, ss command ignores it if PACKET_DIAG_MEMINFO is available.

Better to add new netlink field see net/packet/diag.c.

Maybe time for PACKET_DIAG_STATS with name/value like ethtool.