[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240827095712.2672820-2-frank.li@vivo.com>
Date: Tue, 27 Aug 2024 03:57:04 -0600
From: Yangtao Li <frank.li@...o.com>
To: clement.leger@...tlin.com,
andrew@...n.ch,
f.fainelli@...il.com,
olteanv@...il.com,
davem@...emloft.net,
edumazet@...gle.com,
kuba@...nel.org,
pabeni@...hat.com,
ulli.kroll@...glemail.com,
linus.walleij@...aro.org,
marcin.s.wojtas@...il.com,
linux@...linux.org.uk,
alexandre.torgue@...s.st.com,
joabreu@...opsys.com,
mcoquelin.stm32@...il.com,
hkallweit1@...il.com,
u.kleine-koenig@...gutronix.de,
jacob.e.keller@...el.com,
justinstitt@...gle.com,
sd@...asysnail.net,
horms@...nel.org
Cc: linux-renesas-soc@...r.kernel.org,
netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-stm32@...md-mailman.stormreply.com,
Yangtao Li <frank.li@...o.com>,
Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: [net-next v3 1/9] net: stmmac: dwmac-intel-plat: Convert to devm_clk_get_enabled()
Convert devm_clk_get(), clk_prepare_enable() to a single
call to devm_clk_get_enabled(), as this is exactly
what this function does.
Signed-off-by: Yangtao Li <frank.li@...o.com>
Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
---
.../net/ethernet/stmicro/stmmac/dwmac-intel-plat.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c
index d68f0c4e7835..dcbae653ab8c 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c
@@ -104,12 +104,10 @@ static int intel_eth_plat_probe(struct platform_device *pdev)
/* Enable TX clock */
if (dwmac->data->tx_clk_en) {
- dwmac->tx_clk = devm_clk_get(&pdev->dev, "tx_clk");
+ dwmac->tx_clk = devm_clk_get_enabled(&pdev->dev, "tx_clk");
if (IS_ERR(dwmac->tx_clk))
return PTR_ERR(dwmac->tx_clk);
- clk_prepare_enable(dwmac->tx_clk);
-
/* Check and configure TX clock rate */
rate = clk_get_rate(dwmac->tx_clk);
if (dwmac->data->tx_clk_rate &&
@@ -149,20 +147,15 @@ static int intel_eth_plat_probe(struct platform_device *pdev)
}
ret = stmmac_dvr_probe(&pdev->dev, plat_dat, &stmmac_res);
- if (ret) {
- clk_disable_unprepare(dwmac->tx_clk);
+ if (ret)
return ret;
- }
return 0;
}
static void intel_eth_plat_remove(struct platform_device *pdev)
{
- struct intel_dwmac *dwmac = get_stmmac_bsp_priv(&pdev->dev);
-
stmmac_pltfr_remove(pdev);
- clk_disable_unprepare(dwmac->tx_clk);
}
static struct platform_driver intel_eth_plat_driver = {
--
2.39.0
Powered by blists - more mailing lists