netdev - RE: [PATCH net-next v28 07/13] rtase: Implement a function to receive packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1036b59d9aa541db9b59a0cdc5868d9c@realtek.com>
Date: Tue, 27 Aug 2024 10:46:43 +0000
From: Larry Chiu <larry.chiu@...ltek.com>
To: Paolo Abeni <pabeni@...hat.com>, Justin Lai <justinlai0215@...ltek.com>,
        "kuba@...nel.org" <kuba@...nel.org>
CC: "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com"
	<edumazet@...gle.com>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        "horms@...nel.org" <horms@...nel.org>,
        "rkannoth@...vell.com" <rkannoth@...vell.com>,
        "jdamato@...tly.com"
	<jdamato@...tly.com>,
        Ping-Ke Shih <pkshih@...ltek.com>
Subject: RE: [PATCH net-next v28 07/13] rtase: Implement a function to receive packets


> > +
> > +             skb = build_skb(ring->data_buf[entry], PAGE_SIZE);
> > +             if (!skb) {
> > +                     netdev_err(dev, "skb build failed\n");
> 
> I'm sorry for this late feedback, but the above message should be
> dropped, too.
> 
> As pointed out by Jakub in the previous revision, this allocation can
> fail, and the counter increase below will give exactly the same amount
> of information, without potentially filling the dmseg buffer.
> 
> FWIW, I think the above is the last item pending.
> 
> Thanks,
> 
> Paolo

Thank you for taking the time to review.
We will remove it in the next version.

Larry