netdev - Re: [PATCH] net: dsa: microchip: Use standard regmap locking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36f312eb-150e-4497-84f0-6bfbaab16d9b@redhat.com>
Date: Tue, 27 Aug 2024 14:54:52 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Mark Brown <broonie@...nel.org>, Woojung Huh <woojung.huh@...rochip.com>,
 UNGLinuxDriver@...rochip.com, Andrew Lunn <andrew@...n.ch>,
 Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean
 <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: dsa: microchip: Use standard regmap locking

On 8/22/24 21:53, Mark Brown wrote:
> For unclear reasons the ksz drivers use custom regmap locking which is
> simply a wrapper around a standard mutex. 

According to the commit introducing such lock, 
013572a236ef53cbd1e315e0acf2ee632cc816d4
the ksz driver family one regmap per register width (8/16/32), accessing 
the same set of registers.

The locking implemented with the code removed here allows serializing 
operations using different register widths.

Thanks,

Paolo