netdev - Re: [PATCH v4 net-next 00/12] net: introduce TX H/W shaping API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240827065304.05ae49a9@kernel.org>
Date: Tue, 27 Aug 2024 06:53:04 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, Jiri Pirko <jiri@...nulli.us>, Madhu Chittim
 <madhu.chittim@...el.com>, Sridhar Samudrala <sridhar.samudrala@...el.com>,
 Simon Horman <horms@...nel.org>, John Fastabend <john.fastabend@...il.com>,
 Sunil Kovvuri Goutham <sgoutham@...vell.com>, Jamal Hadi Salim
 <jhs@...atatu.com>, Donald Hunter <donald.hunter@...il.com>
Subject: Re: [PATCH v4 net-next 00/12] net: introduce TX H/W shaping API

On Tue, 27 Aug 2024 09:54:52 +0200 Paolo Abeni wrote:
> > For the case above we could technically identify the correct parent by
> > skipping the nodes which will be garbage collected later.   
> 
> I think that implementation would be quite non trivial/error prone, and 
> I think making the new root's parent explicit would be more clear from 
> user-space perspective.
> 
> What I have now in my local tree is a group() implementation the 
> inherits the newly created root's parent handle from the leaves, if all 
> of them have the same parent prior to the group() invocation. Otherwise 
> it requires the user to specify the root's parent handle. In any case, 
> the user-specified root's parent handle value overrides the 
> 'inherited'/guessed one.
> 
> It will cover the above and will not require an explicit parent in most 
> case. Would that be good enough?

Yes, that's great.