netdev - Re: [PATCH net-next] idpf: Slightly simplify memory management in idpf_add_del_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a16c0444-a289-4a84-b6eb-b06b4a3ef1f9@intel.com>
Date: Tue, 27 Aug 2024 16:09:21 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>, Christophe JAILLET
	<christophe.jaillet@...adoo.fr>
CC: Tony Nguyen <anthony.l.nguyen@...el.com>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	<linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
	<intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>, "Pavan Kumar
 Linga" <pavan.kumar.linga@...el.com>, Dan Carpenter
	<dan.carpenter@...aro.org>
Subject: Re: [PATCH net-next] idpf: Slightly simplify memory management in
 idpf_add_del_mac_filters()

From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Date: Tue, 27 Aug 2024 08:58:33 +0200

> On 8/26/24 19:14, Christophe JAILLET wrote:
>> Le 26/08/2024 à 11:15, Przemek Kitszel a écrit :
>>> On 8/23/24 11:10, Dan Carpenter wrote:
>>>> On Fri, Aug 23, 2024 at 08:23:29AM +0200, Christophe JAILLET wrote:
> 
>>>> It would be even nicer to move the ma_list allocation outside the loop:
>>>>
>>>>          buf_size = struct_size(ma_list, mac_addr_list,
>>>> IDPF_NUM_FILTERS_PER_MSG);
>>>>          ma_list = kmalloc(buf_size, GFP_ATOMIC);

[...]

>> So, I'm not sure to understand what you propose, or the code in
>> idpf_add_del_mac_filters() and co.
>>
>>>
>>> CCing author; CCing Olek to ask if there are already some refactors that
>>> would conflict with this.

I'm not aware of any MAC filter code refactors.

>>
>> I'll way a few days for these feedbacks and send a v2.
> 
> Would be good to have simple memory cleanup first, and later (if at all)
> to untangle our locks a bit.

Thanks,
Olek