netdev - Re: [PATCH -next] net: txgbe: use pci_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240827144256.GF1368797@kernel.org>
Date: Tue, 27 Aug 2024 15:42:56 +0100
From: Simon Horman <horms@...nel.org>
To: Yu Liao <liaoyu15@...wei.com>
Cc: jiawenwu@...stnetic.com, mengyuanlou@...-swift.com, liwei391@...wei.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH -next] net: txgbe: use pci_dev_id() helper

On Mon, Aug 26, 2024 at 09:21:00AM +0800, Yu Liao wrote:
> PCI core API pci_dev_id() can be used to get the BDF number for a PCI
> device. We don't need to compose it manually. Use pci_dev_id() to
> simplify the code a little bit.
> 
> Signed-off-by: Yu Liao <liaoyu15@...wei.com>

Thanks Yu Liao,

I agree that pci_dev_id() was being open coded here.
And that it is nicer to use that helper.

Reviewed-by: Simon Horman <horms@...nel.org>