netdev - Re: [RFC net-next] net: macb: add support for configuring eee via ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3c5a3db5-a598-454e-807a-b5106008aa40@lunn.ch>
Date: Tue, 27 Aug 2024 17:29:28 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Conor Dooley <conor@...nel.org>
Cc: netdev@...r.kernel.org, Steve Wilkins <steve.wilkins@...marine.com>,
	Conor Dooley <conor.dooley@...rochip.com>,
	valentina.fernandezalanis@...rochip.com,
	Nicolas Ferre <nicolas.ferre@...rochip.com>,
	Claudiu Beznea <claudiu.beznea@...on.dev>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Russell King <linux@...linux.org.uk>, linux-kernel@...r.kernel.org
Subject: Re: [RFC net-next] net: macb: add support for configuring eee via
 ethtool

On Tue, Aug 27, 2024 at 12:29:23PM +0100, Conor Dooley wrote:
> From: Steve Wilkins <steve.wilkins@...marine.com>
> 
> Add ethtool_ops for configuring Energy Efficient Ethernet in the PHY.
> 
> Signed-off-by: Steve Wilkins <steve.wilkins@...marine.com>
> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> ---
> Steve sent me this patch (modulo the eee -> keee change), but I know
> nothing about the macb driver, so I asked Nicolas whether the patch
> made sense. His response was:
> > Interesting although I have the feeling that some support from our MAC
> > is missing for pretending to support the feature.
> > I'm not sure the phylink without the MAC support is valid.
> >
> > I think we need a real task to be spawn to support EEE / LPI on cadence
> > driver (but I don't see it scheduled in a way or another 🙁 ).
> 
> Since he was not sure, next port of call is lkml.. Is this patch
> sufficient in isolation, or are additional changes required to the driver
> for it?
> 
> The other drivers that I looked at that use phylink_ethtool_set_eee()
> vary between doing what's done here and just forwarding the call, but
> others are more complex, so without an understanding of the subsystem
> I cannot tell :)
> 
> Alternatively, Steve, shout if you can tell me why forwarding to the phy
> is sufficient, and I'll update the commit message and send this as
> non-RFC.

This is not sufficient. EEE is negotiated with the link peer, so
phylib/phylink is involved so that negotiation is performed, and the
results reported back to the MAC.

The MAC then needs to act on the results of the negotiation. The MAC
does most of the work. It keeps a timer of when it last sent a
packet. If this time exceeds 'tx-timer', it signals to the PHY it can
swap into low power mode, because there is nothing to send. When the
next packet comes along, it needs to signal the PHY to transition back
into full power mode, and it needs to wait a little for that to
happen.

You are missing the MAC parts.

	Andrew