[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b8cf0639-7fe1-4225-9d95-ffd3caef595b@denx.de>
Date: Tue, 27 Aug 2024 18:31:57 +0200
From: Marek Vasut <marex@...x.de>
To: Alexis Lothoré <alexis.lothore@...tlin.com>,
linux-wireless@...r.kernel.org
Cc: Ajay Singh <ajay.kathat@...rochip.com>,
"David S. Miller" <davem@...emloft.net>,
Adham Abozaeid <adham.abozaeid@...rochip.com>,
Claudiu Beznea <claudiu.beznea@...on.dev>, Conor Dooley
<conor+dt@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Kalle Valo <kvalo@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org,
netdev@...r.kernel.org
Subject: Re: [PATCH v2 4/4] wifi: wilc1000: Add WILC3000 support
On 8/27/24 10:28 AM, Alexis Lothoré wrote:
Hi,
>> @@ -1467,6 +1604,20 @@ static int init_chip(struct net_device *dev)
>> }
>> }
>>
>> + if (is_wilc3000(wilc->chipid)) {
>> + ret = wilc->hif_func->hif_read_reg(wilc, 0x207ac, ®);
>
> Some defines would be nice here instead of hardcoded addresses. I have asked
> Ajay about those while working on wilc3000, the meaning is roughly the following:
> - 0x000207ac: WILC_3000_BOOTROM_STATUS_REGISTER
> - 0x004f0000: WILC_3000_CORTUS_BOOT_REGISTER_2
> - 0x71: WILC_CORTUS_BOOT_FROM_IRAM
Fixed in V3, thanks.
Powered by blists - more mailing lists