netdev - Re: [PATCH net-next 1/2] tcp: remove volatile qualifier on tw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL+tcoATM_Gkj_wq+myVD-y1JQ_NOeiCpxgV=dZLxgn2-woS4Q@mail.gmail.com>
Date: Tue, 27 Aug 2024 11:16:43 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 1/2] tcp: remove volatile qualifier on tw_substate

On Tue, Aug 27, 2024 at 9:53 AM Eric Dumazet <edumazet@...gle.com> wrote:
>
> Using a volatile qualifier for a specific struct field is unusual.
>
> Use instead READ_ONCE()/WRITE_ONCE() where necessary.
>
> tcp_timewait_state_process() can change tw_substate while other
> threads are reading this field.

Yes, it can happen.

>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Jason Xing <kerneljasonxing@...il.com>

Thanks!