netdev - Re: [PATCH v2 net-next 5/5] ionic: convert Rx queue buffers to use page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202408280318.gE2lxcpO-lkp@intel.com>
Date: Wed, 28 Aug 2024 03:59:05 +0800
From: kernel test robot <lkp@...el.com>
To: Brett Creeley <brett.creeley@....com>, netdev@...r.kernel.org,
	davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com,
	pabeni@...hat.com
Cc: oe-kbuild-all@...ts.linux.dev, shannon.nelson@....com,
	brett.creeley@....com
Subject: Re: [PATCH v2 net-next 5/5] ionic: convert Rx queue buffers to use
 page_pool

Hi Brett,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Brett-Creeley/ionic-debug-line-for-Tx-completion-errors/20240827-024626
base:   net-next/main
patch link:    https://lore.kernel.org/r/20240826184422.21895-6-brett.creeley%40amd.com
patch subject: [PATCH v2 net-next 5/5] ionic: convert Rx queue buffers to use page_pool
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20240828/202408280318.gE2lxcpO-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240828/202408280318.gE2lxcpO-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408280318.gE2lxcpO-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from include/linux/kernel.h:28,
                    from include/linux/skbuff.h:13,
                    from include/linux/ip.h:16,
                    from drivers/net/ethernet/pensando/ionic/ionic_txrx.c:4:
   drivers/net/ethernet/pensando/ionic/ionic_txrx.c: In function 'ionic_rx_build_skb':
>> include/linux/minmax.h:93:37: warning: conversion from 'long unsigned int' to 'u16' {aka 'short unsigned int'} changes value from '65536' to '0' [-Woverflow]
      93 |         ({ type ux = (x); type uy = (y); __cmp(op, ux, uy); })
         |                                     ^
   include/linux/minmax.h:96:9: note: in expansion of macro '__cmp_once_unique'
      96 |         __cmp_once_unique(op, type, x, y, __UNIQUE_ID(x_), __UNIQUE_ID(y_))
         |         ^~~~~~~~~~~~~~~~~
   include/linux/minmax.h:213:27: note: in expansion of macro '__cmp_once'
     213 | #define min_t(type, x, y) __cmp_once(min, type, x, y)
         |                           ^~~~~~~~~~
   drivers/net/ethernet/pensando/ionic/ionic_txrx.c:203:28: note: in expansion of macro 'min_t'
     203 |                 frag_len = min_t(u16, len, IONIC_PAGE_SIZE);
         |                            ^~~~~
   drivers/net/ethernet/pensando/ionic/ionic_txrx.c: In function 'ionic_rx_fill':
>> include/linux/minmax.h:93:37: warning: conversion from 'long unsigned int' to 'u16' {aka 'short unsigned int'} changes value from '65536' to '0' [-Woverflow]
      93 |         ({ type ux = (x); type uy = (y); __cmp(op, ux, uy); })
         |                                     ^
   include/linux/minmax.h:96:9: note: in expansion of macro '__cmp_once_unique'
      96 |         __cmp_once_unique(op, type, x, y, __UNIQUE_ID(x_), __UNIQUE_ID(y_))
         |         ^~~~~~~~~~~~~~~~~
   include/linux/minmax.h:213:27: note: in expansion of macro '__cmp_once'
     213 | #define min_t(type, x, y) __cmp_once(min, type, x, y)
         |                           ^~~~~~~~~~
   drivers/net/ethernet/pensando/ionic/ionic_txrx.c:797:34: note: in expansion of macro 'min_t'
     797 |                 first_frag_len = min_t(u16, len, IONIC_PAGE_SIZE);
         |                                  ^~~~~
>> include/linux/minmax.h:93:37: warning: conversion from 'long unsigned int' to 'u16' {aka 'short unsigned int'} changes value from '65536' to '0' [-Woverflow]
      93 |         ({ type ux = (x); type uy = (y); __cmp(op, ux, uy); })
         |                                     ^
   include/linux/minmax.h:96:9: note: in expansion of macro '__cmp_once_unique'
      96 |         __cmp_once_unique(op, type, x, y, __UNIQUE_ID(x_), __UNIQUE_ID(y_))
         |         ^~~~~~~~~~~~~~~~~
   include/linux/minmax.h:213:27: note: in expansion of macro '__cmp_once'
     213 | #define min_t(type, x, y) __cmp_once(min, type, x, y)
         |                           ^~~~~~~~~~
   drivers/net/ethernet/pensando/ionic/ionic_txrx.c:832:36: note: in expansion of macro 'min_t'
     832 |                         frag_len = min_t(u16, remain_len, IONIC_PAGE_SIZE);
         |                                    ^~~~~


vim +93 include/linux/minmax.h

d03eba99f5bf7c David Laight   2023-09-18  91  
017fa3e8918784 Linus Torvalds 2024-07-28  92  #define __cmp_once_unique(op, type, x, y, ux, uy) \
017fa3e8918784 Linus Torvalds 2024-07-28 @93  	({ type ux = (x); type uy = (y); __cmp(op, ux, uy); })
017fa3e8918784 Linus Torvalds 2024-07-28  94  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki