netdev - Re: [net-next v4 4/5] net: stmmac: Add PCI driver support for BCM8958x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f104127-c140-4b05-830e-80c34617b629@marvell.com>
Date: Wed, 28 Aug 2024 02:02:20 +0530
From: Amit Singh Tomar <amitsinght@...vell.com>
To: Jitendra Vegiraju <jitendra.vegiraju@...adcom.com>
Cc: netdev@...r.kernel.org, alexandre.torgue@...s.st.com, joabreu@...opsys.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, mcoquelin.stm32@...il.com,
        bcm-kernel-feedback-list@...adcom.com, richardcochran@...il.com,
        ast@...nel.org, daniel@...earbox.net, hawk@...nel.org,
        john.fastabend@...il.com, fancer.lancer@...il.com,
        rmk+kernel@...linux.org.uk, ahalaney@...hat.com,
        xiaolei.wang@...driver.com, rohan.g.thomas@...el.com,
        Jianheng.Zhang@...opsys.com, linux-kernel@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, bpf@...r.kernel.org,
        andrew@...n.ch, linux@...linux.org.uk, horms@...nel.org,
        florian.fainelli@...adcom.com
Subject: Re: [net-next v4 4/5] net: stmmac: Add PCI driver support for
 BCM8958x

Hi,
> 
> Hi Amit,
> Thanks for the review comments.
> 
> On Thu, Aug 22, 2024 at 9:35 AM Amit Singh Tomar <amitsinght@...vell.com> wrote:
>>
>> Hi,
>>
>>
>> > +{
>> > +     int ret;
>> > +     int i;
>> nit: This can be merged into single line.
> 
> Thanks, I will fix it.
> 
>> > +err_disable_msi:
>> > +     pci_free_irq_vectors(pdev);
>> > +err_disable_device:
>> > +     pci_disable_device(pdev);
>> Shouldn't pcim_iounmap_region be called here to unmap and release PCI BARs?
> 
> My understanding is that for managed API calls pcim_iomap_regions(),
> we don't need to do explicit clean up.
> Please let me know if that's not the case.
> Just realized that pci_disable_device() in cleanup is not required
> since the driver is using pcim_enable_device().
> 
You're right, I just looked into the pcim_iomap_regions(), and it seems 
to handle the cleanup process itself.
https://elixir.bootlin.com/linux/v6.10.6/source/drivers/pci/devres.c#L387

Thanks,
-Amit