netdev - Re: [PATCH net-next v2] l2tp: avoid using drain_workqueue in l2tp_pre_exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <172479123225.757308.14877891205035162893.git-patchwork-notify@kernel.org>
Date: Tue, 27 Aug 2024 20:40:32 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: James Chapman <jchapman@...alix.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, dsahern@...nel.org, tparkin@...alix.com,
 xiyou.wangcong@...il.com
Subject: Re: [PATCH net-next v2] l2tp: avoid using drain_workqueue in
 l2tp_pre_exit_net

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Fri, 23 Aug 2024 15:22:57 +0100 you wrote:
> Recent commit fc7ec7f554d7 ("l2tp: delete sessions using work queue")
> incorrectly uses drain_workqueue. The use of drain_workqueue in
> l2tp_pre_exit_net is flawed because the workqueue is shared by all
> nets and it is therefore possible for new work items to be queued
> for other nets while drain_workqueue runs.
> 
> Instead of using drain_workqueue, use __flush_workqueue twice. The
> first one will run all tunnel delete work items and any work already
> queued. When tunnel delete work items are run, they may queue
> new session delete work items, which the second __flush_workqueue will
> run.
> 
> [...]

Here is the summary with links:
  - [net-next,v2] l2tp: avoid using drain_workqueue in l2tp_pre_exit_net
    https://git.kernel.org/netdev/net-next/c/73d33bd063c4

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html