netdev - Re: [PATCH 1/1 V2] Selftests: net: Set executable bit for shell script

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240827144448.64524df3@kernel.org>
Date: Tue, 27 Aug 2024 14:44:48 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: David Hunter <david.hunter.linux@...il.com>
Cc: davem@...emloft.net, edumazet@...gle.com,
 javier.carrasco.cruz@...il.com, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, netdev@...r.kernel.org, pabeni@...hat.com,
 shuah@...nel.org
Subject: Re: [PATCH 1/1 V2] Selftests: net: Set executable bit for shell
 script

On Tue, 27 Aug 2024 17:37:21 -0400 David Hunter wrote:
> On  Mon, 26 Aug 2024 14:40:22 -0700 Jakub Kicinski wrote:
> > What is linux_mainline and how does one download from it?  
> 
> The Linux Mainline source files can be downloaded using the following command:
> 
> git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git linux_mainline
> 
> I meant to say "Linux Mainline". In my computer, I put the title for
> the directory as "linux_mainline", so I have a habit of putting the
> underscore when I should not. 

I see. But going back to the commit message - why would the files be
skipped? At some point you shared a warning which gets printed:

 # Warning: file test_ingress_egress_chaining.sh is not executable

that's a better thing to put in the commit message, than talking 
about downloading.

Keep in mind you need to put a space or two before the # otherwise
git will think it's a comment.