netdev - Re: [PATCH net-next v2 1/2] net/ncsi: Use str_up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zs16fFk7sDIhcMP8@mev-dev.igk.intel.com>
Date: Tue, 27 Aug 2024 09:04:28 +0200
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Hongbo Li <lihongbo22@...wei.com>
Cc: sam@...dozajonas.com, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/2] net/ncsi: Use str_up_down to simplify
 the code

On Tue, Aug 27, 2024 at 10:52:45AM +0800, Hongbo Li wrote:
> As str_up_down is the common helper to reback "up/down"
> string, we can replace the target with it to simplify
> the code and fix the coccinelle warning.
> 
> Signed-off-by: Hongbo Li <lihongbo22@...wei.com>
> ---
>  net/ncsi/ncsi-manage.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c
> index 5ecf611c8820..13b4d393fb2d 100644
> --- a/net/ncsi/ncsi-manage.c
> +++ b/net/ncsi/ncsi-manage.c
> @@ -1281,7 +1281,7 @@ static int ncsi_choose_active_channel(struct ncsi_dev_priv *ndp)
>  				netdev_dbg(ndp->ndev.dev,
>  					   "NCSI: Channel %u added to queue (link %s)\n",
>  					   nc->id,
> -					   ncm->data[2] & 0x1 ? "up" : "down");
> +					   str_up_down(ncm->data[2] & 0x1));
Are you basing the commit on sth else than net-next? I can't see such
helper in the repo.

>  			}
>  
>  			spin_unlock_irqrestore(&nc->lock, cflags);
> -- 
> 2.34.1
> 

You have the same commit message in both patches, they can be merged
into one I think.

Thanks,
Michal