[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e8420765-dec6-4802-8255-89f9f6965c59@uliege.be>
Date: Tue, 27 Aug 2024 09:41:45 +0200
From: Justin Iurman <justin.iurman@...ege.be>
To: Stephen Hemminger <stephen@...workplumber.org>
Cc: netdev@...r.kernel.org, dsahern@...nel.org
Subject: Re: [PATCH iproute2-next v2 1/2] ip: lwtunnel: tunsrc support
On 8/26/24 17:59, Stephen Hemminger wrote:
> On Mon, 26 Aug 2024 15:52:28 +0200
> Justin Iurman <justin.iurman@...ege.be> wrote:
>
>> - if (mode != IOAM6_IPTUNNEL_MODE_INLINE)
>> + if (mode != IOAM6_IPTUNNEL_MODE_INLINE) {
>> + if (tb[IOAM6_IPTUNNEL_SRC]) {
>> + print_string(PRINT_ANY, "tunsrc", "tunsrc %s ",
>> + rt_addr_n2a_rta(AF_INET6,
>> + tb[IOAM6_IPTUNNEL_SRC]));
>> + }
>> +
>> print_string(PRINT_ANY, "tundst", "tundst %s ",
>> rt_addr_n2a_rta(AF_INET6, tb[IOAM6_IPTUNNEL_DST]));
>> + }
>
> Looks good.
> These strings should be printed with
> print_color_string(PRINT_ANY, COLOR_INET6, ...
>
> but that is not urgent. Just to follow convention.
Ack, thanks! I can submit -v3 now to include the change though. WDYT?
Powered by blists - more mailing lists