netdev - Re: [PATCH net-next v7 4/6] rust: net::phy unified read/write API for C22 and C45 registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20240828.074835.1208741310226632116.fujita.tomonori@gmail.com>
Date: Wed, 28 Aug 2024 07:48:35 +0000 (UTC)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: kuba@...nel.org
Cc: tmgross@...ch.edu, fujita.tomonori@...il.com, netdev@...r.kernel.org,
 rust-for-linux@...r.kernel.org, andrew@...n.ch,
 miguel.ojeda.sandonis@...il.com, benno.lossin@...ton.me,
 aliceryhl@...gle.com
Subject: Re: [PATCH net-next v7 4/6] rust: net::phy unified read/write API
 for C22 and C45 registers

On Tue, 27 Aug 2024 14:14:14 -0700
Jakub Kicinski <kuba@...nel.org> wrote:

> On Sat, 24 Aug 2024 00:44:50 -0500 Trevor Gross wrote:
>> Small suggestion: I think these could all be `#[derive(Clone, Copy,
>> Debug)]` so they are easy to `pr_info!(...)`. C45 doesn't have any
>> derives.
>> 
>> This could probably be done when it is picked up if there isn't another version.
> 
> Please respin, it's not too much work. It's really rare that'd edit
> people's code when applying in networking. The commit message yes
> but code very rarely.

Sure, I've just send v8.