netdev - Re: [PATCH net-next 7/8] net/rxrpc: Use min() to simplify the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <948381.1724833077@warthog.procyon.org.uk>
Date: Wed, 28 Aug 2024 09:17:57 +0100
From: David Howells <dhowells@...hat.com>
To: Hongbo Li <lihongbo22@...wei.com>
Cc: dhowells@...hat.com, johannes@...solutions.net, davem@...emloft.net,
    edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
    allison.henderson@...cle.com, dsahern@...nel.org, pshelar@....org,
    linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
    rds-devel@....oracle.com, dccp@...r.kernel.org, dev@...nvswitch.org,
    linux-afs@...ts.infradead.org
Subject: Re: [PATCH net-next 7/8] net/rxrpc: Use min() to simplify the code

Hongbo Li <lihongbo22@...wei.com> wrote:

> I see reason is u8, so may I use min_t(u8, sp->ack.reason,
> RXRPC_ACK__INVALID)?

No, please don't use min_t(<unsigned type>, ...) if umin() will do.  IIRC,
some arches can't do byte-level arithmetic.

Thanks,
David