netdev - Re: [PATCH net-next 1/6] net: ethernet: fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <27fc0052-c7d6-455b-933c-4b1dc6f4a95b@csgroup.eu>
Date: Wed, 28 Aug 2024 12:12:46 +0200
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Maxime Chevallier <maxime.chevallier@...tlin.com>, davem@...emloft.net,
 Pantelis Antoniou <pantelis.antoniou@...il.com>, Andrew Lunn
 <andrew@...n.ch>, Jakub Kicinski <kuba@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Russell King <linux@...linux.org.uk>, Florian Fainelli
 <f.fainelli@...il.com>, Heiner Kallweit <hkallweit1@...il.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 thomas.petazzoni@...tlin.com, Herve Codina <herve.codina@...tlin.com>,
 linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH net-next 1/6] net: ethernet: fs_enet: convert to SPDX



Le 28/08/2024 à 11:50, Maxime Chevallier a écrit :
> The ENET driver has SPDX tags in the header files, but they were missing
> in the C files. Change the licence information to SPDX format.

AFAIK you have to CC linux-spdx@...r.kernel.org for this kind of change.

> 
> Signed-off-by: Maxime Chevallier <maxime.chevallier@...tlin.com>

Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>

> ---
>   drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 5 +----
>   drivers/net/ethernet/freescale/fs_enet/mac-fcc.c      | 5 +----
>   drivers/net/ethernet/freescale/fs_enet/mac-fec.c      | 5 +----
>   drivers/net/ethernet/freescale/fs_enet/mac-scc.c      | 5 +----
>   drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c  | 5 +----
>   drivers/net/ethernet/freescale/fs_enet/mii-fec.c      | 5 +----
>   6 files changed, 6 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> index cf392faa6105..5bfdd43ffdeb 100644
> --- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> +++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-only
>   /*
>    * Combined Ethernet driver for Motorola MPC8xx and MPC82xx.
>    *
> @@ -9,10 +10,6 @@
>    *
>    * Heavily based on original FEC driver by Dan Malek <dan@...eddededge.com>
>    * and modifications by Joakim Tjernlund <joakim.tjernlund@...entis.se>
> - *
> - * This file is licensed under the terms of the GNU General Public License
> - * version 2. This program is licensed "as is" without any warranty of any
> - * kind, whether express or implied.
>    */
>   
>   #include <linux/module.h>
> diff --git a/drivers/net/ethernet/freescale/fs_enet/mac-fcc.c b/drivers/net/ethernet/freescale/fs_enet/mac-fcc.c
> index e2ffac9eb2ad..add062928d99 100644
> --- a/drivers/net/ethernet/freescale/fs_enet/mac-fcc.c
> +++ b/drivers/net/ethernet/freescale/fs_enet/mac-fcc.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-only
>   /*
>    * FCC driver for Motorola MPC82xx (PQ2).
>    *
> @@ -6,10 +7,6 @@
>    *
>    * 2005 (c) MontaVista Software, Inc.
>    * Vitaly Bordug <vbordug@...mvista.com>
> - *
> - * This file is licensed under the terms of the GNU General Public License
> - * version 2. This program is licensed "as is" without any warranty of any
> - * kind, whether express or implied.
>    */
>   
>   #include <linux/module.h>
> diff --git a/drivers/net/ethernet/freescale/fs_enet/mac-fec.c b/drivers/net/ethernet/freescale/fs_enet/mac-fec.c
> index cdc89d83cf07..f75acb3b358f 100644
> --- a/drivers/net/ethernet/freescale/fs_enet/mac-fec.c
> +++ b/drivers/net/ethernet/freescale/fs_enet/mac-fec.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-only
>   /*
>    * Freescale Ethernet controllers
>    *
> @@ -6,10 +7,6 @@
>    *
>    * 2005 (c) MontaVista Software, Inc.
>    * Vitaly Bordug <vbordug@...mvista.com>
> - *
> - * This file is licensed under the terms of the GNU General Public License
> - * version 2. This program is licensed "as is" without any warranty of any
> - * kind, whether express or implied.
>    */
>   
>   #include <linux/module.h>
> diff --git a/drivers/net/ethernet/freescale/fs_enet/mac-scc.c b/drivers/net/ethernet/freescale/fs_enet/mac-scc.c
> index 9e89ac2b6ce3..29ba0048396b 100644
> --- a/drivers/net/ethernet/freescale/fs_enet/mac-scc.c
> +++ b/drivers/net/ethernet/freescale/fs_enet/mac-scc.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-only
>   /*
>    * Ethernet on Serial Communications Controller (SCC) driver for Motorola MPC8xx and MPC82xx.
>    *
> @@ -6,10 +7,6 @@
>    *
>    * 2005 (c) MontaVista Software, Inc.
>    * Vitaly Bordug <vbordug@...mvista.com>
> - *
> - * This file is licensed under the terms of the GNU General Public License
> - * version 2. This program is licensed "as is" without any warranty of any
> - * kind, whether express or implied.
>    */
>   
>   #include <linux/module.h>
> diff --git a/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c b/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c
> index f965a2329055..2e210a003558 100644
> --- a/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c
> +++ b/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-only
>   /*
>    * Combined Ethernet driver for Motorola MPC8xx and MPC82xx.
>    *
> @@ -6,10 +7,6 @@
>    *
>    * 2005 (c) MontaVista Software, Inc.
>    * Vitaly Bordug <vbordug@...mvista.com>
> - *
> - * This file is licensed under the terms of the GNU General Public License
> - * version 2. This program is licensed "as is" without any warranty of any
> - * kind, whether express or implied.
>    */
>   
>   #include <linux/module.h>
> diff --git a/drivers/net/ethernet/freescale/fs_enet/mii-fec.c b/drivers/net/ethernet/freescale/fs_enet/mii-fec.c
> index 7bb69727952a..93d91e8ad0de 100644
> --- a/drivers/net/ethernet/freescale/fs_enet/mii-fec.c
> +++ b/drivers/net/ethernet/freescale/fs_enet/mii-fec.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-only
>   /*
>    * Combined Ethernet driver for Motorola MPC8xx and MPC82xx.
>    *
> @@ -6,10 +7,6 @@
>    *
>    * 2005 (c) MontaVista Software, Inc.
>    * Vitaly Bordug <vbordug@...mvista.com>
> - *
> - * This file is licensed under the terms of the GNU General Public License
> - * version 2. This program is licensed "as is" without any warranty of any
> - * kind, whether express or implied.
>    */
>   
>   #include <linux/module.h>