netdev - Re: [PATCH net] net: marvell: prestera: Remove unneeded check in prestera_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240828160315.077e3428@device-28.home>
Date: Wed, 28 Aug 2024 16:03:15 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Aleksandr Mishin <amishin@...rgos.ru>
Cc: Vadym Kochan <vadym.kochan@...ision.eu>, Taras Chornyi
 <taras.chornyi@...ision.eu>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Oleksandr Mazur <oleksandr.mazur@...ision.eu>,
 Serhiy Boiko <serhiy.boiko@...ision.eu>, Volodymyr Mytnyk
 <volodymyr.mytnyk@...ision.eu>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <lvc-project@...uxtesting.org>
Subject: Re: [PATCH net] net: marvell: prestera: Remove unneeded check in
 prestera_port_create()

Hello Aleksandr,

On Wed, 28 Aug 2024 16:26:06 +0300
Aleksandr Mishin <amishin@...rgos.ru> wrote:

> prestera_port_create() calls prestera_rxtx_port_init() and analyze its
> return code. prestera_rxtx_port_init() always returns 0, so this check is
> unneeded and should be removed.
> 
> Remove unneeded check to clean up the code.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: 501ef3066c89 ("net: marvell: prestera: Add driver for Prestera family ASIC devices")
> Signed-off-by: Aleksandr Mishin <amishin@...rgos.ru>
> ---
>  drivers/net/ethernet/marvell/prestera/prestera_main.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c
> index 63ae01954dfc..2d4f6d03b729 100644
> --- a/drivers/net/ethernet/marvell/prestera/prestera_main.c
> +++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c
> @@ -718,9 +718,7 @@ static int prestera_port_create(struct prestera_switch *sw, u32 id)
>  		}
>  	}
>  
> -	err = prestera_rxtx_port_init(port);
> -	if (err)
> -		goto err_port_init;
> +	prestera_rxtx_port_init(port);

If this function always return 0, you might as well change it to return
void. This would avoid future issues if one were to change
prestera_rxtx_port_init() to acually make it return something. It would
then become obvious that the caller doesn't check the return, whereas
with the current patch, we are simply ignoring it.

I also think you can target that patch to net-next, this isn't fixing
any bug, but rather cleans the code up.

Thanks,

Maxime