netdev - Re: [PATCH net-next] net: phy: Modify register address from decimal to hexadecimal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a0dfe854-c479-4165-a16e-4e4a1b2a6200@lunn.ch>
Date: Wed, 28 Aug 2024 16:07:21 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Yajun Deng <yajun.deng@...ux.dev>
Cc: hkallweit1@...il.com, linux@...linux.org.uk, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: Modify register address from decimal
 to hexadecimal

On Wed, Aug 28, 2024 at 08:59:32PM +0800, Yajun Deng wrote:
> Most datasheets will use hexadecimal for register address, modify it
> and make it fit the datasheet better.

802.3 uses decimal. Since these are all 802.3 registers, that is what
you should mostly be looking at. You only need the datasheet when the
device breaks the standard.

This is just pointless churn, so NACK.

In a driver, when there are proprietary registers, feel free to use
hex.

	Andrew