netdev - Re: [PATCH v12 4/5] wifi: brcmfmac: Add optional lpo clock enable support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240828145348.GO1368797@kernel.org>
Date: Wed, 28 Aug 2024 15:53:48 +0100
From: Simon Horman <horms@...nel.org>
To: Jacobe Zang <jacobe.zang@...ion.com>
Cc: arend.vanspriel@...adcom.com, kvalo@...nel.org, marcan@...can.st,
	sven@...npeter.dev, alyssa@...enzweig.io, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	saikrishnag@...vell.com, megi@....cz, bhelgaas@...gle.com,
	duoming@....edu.cn, minipli@...ecurity.net, yajun.deng@...ux.dev,
	stern@...land.harvard.edu, gregkh@...uxfoundation.org,
	christophe.jaillet@...adoo.fr, linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	brcm80211@...ts.linux.dev, brcm80211-dev-list.pdl@...adcom.com,
	nick@...das.com
Subject: Re: [PATCH v12 4/5] wifi: brcmfmac: Add optional lpo clock enable
 support

On Wed, Aug 28, 2024 at 11:49:14AM +0800, Jacobe Zang wrote:
> WiFi modules often require 32kHz clock to function. Add support to
> enable the clock to PCIe driver and move "brcm,bcm4329-fmac" check
> to the top of brcmf_of_probe. Change function prototypes from void
> to int and add appropriate errno's for return values that will be
> send to bus when error occurred.
> 
> Co-developed-by: Ondrej Jirman <megi@....cz>
> Signed-off-by: Ondrej Jirman <megi@....cz>
> Co-developed-by: Arend van Spriel <arend.vanspriel@...adcom.com>
> Signed-off-by: Arend van Spriel <arend.vanspriel@...adcom.com>
> Reviewed-by: Sai Krishna <saikrishnag@...vell.com>
> Signed-off-by: Jacobe Zang <jacobe.zang@...ion.com>

...

> @@ -4452,7 +4454,9 @@ struct brcmf_sdio *brcmf_sdio_probe(struct brcmf_sdio_dev *sdiodev)
>  	/* Allocate private bus interface state */
>  	bus = kzalloc(sizeof(*bus), GFP_ATOMIC);
>  	if (!bus)
> +		ret = -ENOMEM;
>  		goto fail;
> +	}
>  

Perhaps a local change didn't make it into git, or something like that.
But this does not compile.

>  	bus->sdiodev = sdiodev;
>  	sdiodev->bus = bus;

...

-- 
pw-bot: cr