netdev - Re: [PATCH] netfilter: nf_tables: Add __percpu annotation to *stats pointer in nf_tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFULd4Y8tCUNHJ9vVPKch0sMj31LnF8bVtJRTez5tBV9p5509w@mail.gmail.com>
Date: Wed, 28 Aug 2024 21:29:14 +0200
From: Uros Bizjak <ubizjak@...il.com>
To: Pablo Neira Ayuso <pablo@...filter.org>
Cc: netfilter-devel@...r.kernel.org, coreteam@...filter.org, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Jozsef Kadlecsik <kadlec@...filter.org>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH] netfilter: nf_tables: Add __percpu annotation to *stats
 pointer in nf_tables_updchain()

On Wed, Aug 28, 2024 at 4:53 PM Pablo Neira Ayuso <pablo@...filter.org> wrote:
>
> On Tue, Aug 06, 2024 at 12:26:58PM +0200, Uros Bizjak wrote:
> > Compiling nf_tables_api.c results in several sparse warnings:
> >
> > nf_tables_api.c:2740:23: warning: incorrect type in assignment (different address spaces)
> > nf_tables_api.c:2752:38: warning: incorrect type in assignment (different address spaces)
> > nf_tables_api.c:2798:21: warning: incorrect type in argument 1 (different address spaces)
> >
> > Add __percpu annotation to *stats pointer to fix these warnings.
> >
> > Found by GCC's named address space checks.
> >
> > There were no changes in the resulting object files.
>
> I never replied to this.
>
> I can see this is getting things better, but still more sparse
> warnings show up related tho nft_stats. I'd prefer those are fixed at
> ones, would you give it a look?

Yes, I have a follow-up patch that also fixes the remaining warnings,
but it depends on a patch [1] that is on the way to mainline through
the mm tree.

I can post the complete patch that uses percpu variants of ERR_PTR,
IS_ERR and PTR_ERR where needed if this dependency can temporarily be
tolerated.

[1] https://lore.kernel.org/lkml/20240818210235.33481-1-ubizjak@gmail.com/

Thanks,
Uros.