netdev - Re: [PATCH v1] sfc: Convert to use ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240828160132.5553cb1a@kernel.org>
Date: Wed, 28 Aug 2024 16:01:32 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jacob Keller <jacob.e.keller@...el.com>
Cc: Edward Cree <ecree.xilinx@...il.com>, Shen Lichuan
 <shenlichuan@...o.com>, <habetsm.xilinx@...il.com>, <davem@...emloft.net>,
 <edumazet@...gle.com>, <pabeni@...hat.com>, <netdev@...r.kernel.org>,
 <linux-net-drivers@....com>, <linux-kernel@...r.kernel.org>,
 <opensource.kernel@...o.com>
Subject: Re: [PATCH v1] sfc: Convert to use ERR_CAST()

On Wed, 28 Aug 2024 15:31:08 -0700 Jacob Keller wrote:
> Somewhat unrelated but you could cleanup some of the confusion by using
> __free(kfree) annotation from <linux/cleanup.h> to avoid needing to
> manually free ctr in error paths, and just use return_ptr() return the
> value at the end.

Please don't send people towards __free(). In general, but especially as
part of random cleanups.