netdev - Re: [patch net-next v4] ethtool: pse-pd: move pse validation into set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240829103552.09f22f98@device-28.home>
Date: Thu, 29 Aug 2024 10:35:52 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Diogo Jahchan Koike <djahchankoike@...il.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, Christophe Leroy <christophe.leroy@...roup.eu>,
 syzbot+ec369e6d58e210135f71@...kaller.appspotmail.com,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [patch net-next v4] ethtool: pse-pd: move pse validation into
 set

Hi Diogo,

On Wed, 28 Aug 2024 14:43:17 -0300
Diogo Jahchan Koike <djahchankoike@...il.com> wrote:

> Move validation into set, removing .set_validate operation as its current
> implementation holds the rtnl lock for acquiring the PHY device, defeating
> the intended purpose of checking before grabbing the lock.

[...] 

>  static int
> -ethnl_set_pse_validate(struct ethnl_req_info *req_info, struct genl_info *info)
> +ethnl_set_pse_validate(struct phy_device *phydev, struct genl_info *info)
>  {
>  	struct nlattr **tb = info->attrs;
> -	struct phy_device *phydev;
> -
> -	phydev = ethnl_req_get_phydev(req_info, tb[ETHTOOL_A_PSE_HEADER],
> -				      info->extack);
> +	
   ^^^
You have an extra white space here. Make sure you run your patch through
the checkpatch script to detect this kind of issues.

The rest looks good to me. For the next version,

Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>

Thanks,

Maxime