netdev - Re: remove the dma_set_{max_seg_size,seg_boundary,min_align

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1v7zkdu3s.fsf@ca-mkp.ca.oracle.com>
Date: Wed, 28 Aug 2024 20:57:13 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Christoph Hellwig <hch@....de>
Cc: iommu@...ts.linux.dev, "Martin K. Petersen"
 <martin.petersen@...cle.com>,
        Robin Murphy <robin.murphy@....com>,
        Marek
 Szyprowski <m.szyprowski@...sung.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        dmaengine@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-media@...r.kernel.org,
        linux-mmc@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
        linux-hyperv@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: remove the dma_set_{max_seg_size,seg_boundary,min_align_mask}
 return value v2


Christoph,

> the above three functions can only return errors if the bus code
> failed to allocate the dma_parms structure, which is a grave error
> that won't get us far. Thus remove the pointless return values, that
> so far have fortunately been mostly ignored, but which the cleanup
> brigade now wants to check for for no good reason.

Reviewed-by: Martin K. Petersen <martin.petersen@...cle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering