netdev - Re: [PATCH net-next v3 05/13] net: phy: Fix missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60afa68f-677a-490d-8c65-fad9e64beb51@lunn.ch>
Date: Thu, 29 Aug 2024 14:50:29 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: woojung.huh@...rochip.com, f.fainelli@...il.com, olteanv@...il.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, linus.walleij@...aro.org, alsi@...g-olufsen.dk,
	justin.chen@...adcom.com, sebastian.hesselbarth@...il.com,
	alexandre.torgue@...s.st.com, joabreu@...opsys.com, wens@...e.org,
	jernej.skrabec@...il.com, samuel@...lland.org,
	mcoquelin.stm32@...il.com, hkallweit1@...il.com,
	linux@...linux.org.uk, ansuelsmth@...il.com,
	UNGLinuxDriver@...rochip.com, netdev@...r.kernel.org,
	bcm-kernel-feedback-list@...adcom.com,
	linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
	krzk@...nel.org, jic23@...nel.org
Subject: Re: [PATCH net-next v3 05/13] net: phy: Fix missing of_node_put()
 for leds

On Thu, Aug 29, 2024 at 02:31:10PM +0800, Jinjie Ruan wrote:
> The call of of_get_child_by_name() will cause refcount incremented
> for leds, if it succeeds, it should call of_node_put() to decrease
> it, fix it.
> 
> Fixes: 01e5b728e9e4 ("net: phy: Add a binding for PHY LEDs")
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

This is a fix. You were asked to break it out of the series, and post
it to net, not net-next.

Jonathan, please could you step in and do some mentoring. Huawei is
big enough it should not need Maintainers to teach its developers the
basics.

	Andrew