netdev - Re: [PATCH net-next v3 08/13] net: mdio: mux-mmioreg: Simplified with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e47f3ee-bf44-46f2-a080-5dd9ac559cbc@lunn.ch>
Date: Thu, 29 Aug 2024 14:53:10 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: woojung.huh@...rochip.com, f.fainelli@...il.com, olteanv@...il.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, linus.walleij@...aro.org, alsi@...g-olufsen.dk,
	justin.chen@...adcom.com, sebastian.hesselbarth@...il.com,
	alexandre.torgue@...s.st.com, joabreu@...opsys.com, wens@...e.org,
	jernej.skrabec@...il.com, samuel@...lland.org,
	mcoquelin.stm32@...il.com, hkallweit1@...il.com,
	linux@...linux.org.uk, ansuelsmth@...il.com,
	UNGLinuxDriver@...rochip.com, netdev@...r.kernel.org,
	bcm-kernel-feedback-list@...adcom.com,
	linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
	krzk@...nel.org, jic23@...nel.org
Subject: Re: [PATCH net-next v3 08/13] net: mdio: mux-mmioreg: Simplified
 with dev_err_probe()

>  	s->iosize = resource_size(&res);
>  	if (s->iosize != sizeof(uint8_t) &&
>  	    s->iosize != sizeof(uint16_t) &&
>  	    s->iosize != sizeof(uint32_t)) {
> -		dev_err(&pdev->dev, "only 8/16/32-bit registers are supported\n");
> -		return -EINVAL;
> +		return dev_err_probe(&pdev->dev, -EINVAL,
> +				     "only 8/16/32-bit registers are supported\n");

Please think about this change. Why is it wrong?

       Andrew