netdev - Re: [PATCH V5 net-next 04/11] net: hibmcge: Add interrupt supported in this module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <383f26a1-aa8f-4fd2-a00a-86abce5942ad@huawei.com>
Date: Thu, 29 Aug 2024 21:02:47 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <shaojijie@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<pabeni@...hat.com>, <shenjian15@...wei.com>, <wangpeiyang1@...wei.com>,
	<liuyonglong@...wei.com>, <chenhao418@...wei.com>, <sudongming1@...wei.com>,
	<xujunsheng@...wei.com>, <shiyongbang@...wei.com>, <libaihan@...wei.com>,
	<andrew@...n.ch>, <jdamato@...tly.com>, <horms@...nel.org>,
	<jonathan.cameron@...wei.com>, <shameerali.kolothum.thodi@...wei.com>,
	<salil.mehta@...wei.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V5 net-next 04/11] net: hibmcge: Add interrupt supported
 in this module


on 2024/8/29 10:12, Jakub Kicinski wrote:
> On Thu, 29 Aug 2024 09:54:00 +0800 Jijie Shao wrote:
>> on 2024/8/29 9:35, Jakub Kicinski wrote:
>>> On Tue, 27 Aug 2024 21:14:48 +0800 Jijie Shao wrote:
>>>> +	ret = pci_alloc_irq_vectors(priv->pdev, HBG_VECTOR_NUM, HBG_VECTOR_NUM,
>>>> +				    PCI_IRQ_MSI | PCI_IRQ_MSIX);
>>> These are not devm_ -managed, don't you have to free them?
>>> On remove and errors during probe?
>>>   
>> Jonathan Cameron told me:
>> 	I have used pcim_enable(),  so, the irq vectors become device managed.
>> Look for where those paths call pci_setup_msi_context() / pcim_setup_msi_release()
>>
>> So there should be no need to free the vectors on remove()
> Please include change logs in individual patches, going forward.
> Please add this information to the commit message, and remove
> the existing mention of freeing there which is now out of date.

Ok, I'll add a note to that as well.
	Thanks,
	Jijie Shao