netdev - Re: [PATCH v3 2/5] wifi: wilc1000: Fold wilc_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <041331c0-0ab0-473c-a8c4-89fe8e55ae6f@denx.de>
Date: Thu, 29 Aug 2024 02:38:00 +0200
From: Marek Vasut <marex@...x.de>
To: Alexis Lothoré <alexis.lothore@...tlin.com>,
 linux-wireless@...r.kernel.org
Cc: "David S. Miller" <davem@...emloft.net>,
 Adham Abozaeid <adham.abozaeid@...rochip.com>,
 Ajay Singh <ajay.kathat@...rochip.com>,
 Claudiu Beznea <claudiu.beznea@...on.dev>, Conor Dooley
 <conor+dt@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Kalle Valo <kvalo@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH v3 2/5] wifi: wilc1000: Fold wilc_get_chipid() into wlan.c

On 8/28/24 10:39 AM, Alexis Lothoré wrote:
> On 8/27/24 18:37, Marek Vasut wrote:
>> Do not use wilc_get_chipid() outside of wlan.c . Instead, call
>> wilc_get_chipid() right after the SDIO/SPI interface has been
>> initialized to cache the device chipid, and then use the cached
>> chipid throughout the driver. Make wilc_get_chipid() static and
>> remove its prototype from wlan.h . Make wilc_get_chipid() return
>> a proper return value instead of a chipid.
>>
>> Signed-off-by: Marek Vasut <marex@...x.de>
>> ---
>> Cc: "David S. Miller" <davem@...emloft.net>
>> Cc: Adham Abozaeid <adham.abozaeid@...rochip.com>
>> Cc: Ajay Singh <ajay.kathat@...rochip.com>
>> Cc: Alexis Lothoré <alexis.lothore@...tlin.com>
>> Cc: Claudiu Beznea <claudiu.beznea@...on.dev>
>> Cc: Conor Dooley <conor+dt@...nel.org>
>> Cc: Eric Dumazet <edumazet@...gle.com>
>> Cc: Jakub Kicinski <kuba@...nel.org>
>> Cc: Kalle Valo <kvalo@...nel.org>
>> Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>
>> Cc: Marek Vasut <marex@...x.de>
>> Cc: Paolo Abeni <pabeni@...hat.com>
>> Cc: Rob Herring <robh@...nel.org>
>> Cc: devicetree@...r.kernel.org
>> Cc: linux-wireless@...r.kernel.org
>> Cc: netdev@...r.kernel.org
> 
> nit: The remaining wilc_getchipid() call in netdev.c should have been removed in
> this very same commit (it is removed in a later patch in this series, but it
> makes this commit depend on the last one).
> 
> Reviewed-by: Alexis Lothoré <alexis.lothore@...tlin.com>

Fixed in V4, thanks.