netdev - RE: [Intel-wired-lan] [PATCH iwl-next v3 5/6] ice: dump ethtool stats and skb by Tx hang devlink health reporter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CYYPR11MB842931F6813DE0EF8C9F383DBD962@CYYPR11MB8429.namprd11.prod.outlook.com>
Date: Thu, 29 Aug 2024 14:34:55 +0000
From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com>
To: "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>, "Jiri
 Pirko" <jiri@...nulli.us>, "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
CC: "lukas.bulwahn@...il.com" <lukas.bulwahn@...il.com>, "willemb@...gle.com"
	<willemb@...gle.com>, "Drewek, Wojciech" <wojciech.drewek@...el.com>,
	"dwaipayanray1@...il.com" <dwaipayanray1@...il.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Polchlopek, Mateusz"
	<mateusz.polchlopek@...el.com>, "Bagnucki, Igor" <igor.bagnucki@...el.com>,
	"joe@...ches.com" <joe@...ches.com>, Eric Dumazet <edumazet@...gle.com>,
	"Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>, Simon Horman
	<horms@...nel.org>, Jakub Kicinski <kuba@...nel.org>, "apw@...onical.com"
	<apw@...onical.com>, NEX SW NCIS OSDT ITP Upstreaming
	<nex.sw.ncis.osdt.itp.upstreaming@...el.com>, "akpm@...ux-foundation.org"
	<akpm@...ux-foundation.org>, Paolo Abeni <pabeni@...hat.com>, "David S.
 Miller" <davem@...emloft.net>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v3 5/6] ice: dump ethtool stats
 and skb by Tx hang devlink health reporter

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Przemek Kitszel
> Sent: Wednesday, August 21, 2024 7:07 PM
> To: intel-wired-lan@...ts.osuosl.org; Jiri Pirko <jiri@...nulli.us>; Nguyen, Anthony L <anthony.l.nguyen@...el.com>
> Cc: lukas.bulwahn@...il.com; willemb@...gle.com; Drewek, Wojciech <wojciech.drewek@...el.com>; dwaipayanray1@...il.com; netdev@...r.kernel.org; Polchlopek, Mateusz <mateusz.polchlopek@...el.com>; Bagnucki, Igor <igor.bagnucki@...el.com>; joe@...ches.com; Eric Dumazet <edumazet@...gle.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; Simon Horman <horms@...nel.org>; Jakub Kicinski <kuba@...nel.org>; apw@...onical.com; NEX SW NCIS OSDT ITP Upstreaming <nex.sw.ncis.osdt.itp.upstreaming@...el.com>; akpm@...ux-foundation.org; Paolo Abeni <pabeni@...hat.com>; David S. Miller <davem@...emloft.net>
> Subject: [Intel-wired-lan] [PATCH iwl-next v3 5/6] ice: dump ethtool stats and skb by Tx hang devlink health reporter
>
> Print the ethtool stats and skb diagnostic information as part of Tx hang devlink health dump.
>
> Move the declarations of ethtool functions that devlink health uses out to a new file: ice_ethtool_common.h
>
> To utilize our existing ethtool code in this context, convert it to non-static.
>
> Reviewed-by: Igor Bagnucki <igor.bagnucki@...el.com>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Signed-off-by: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_ethtool.h  |  2 +
>  .../ethernet/intel/ice/ice_ethtool_common.h   | 19 ++++++++++
>  .../intel/ice/devlink/devlink_health.c        | 37 +++++++++++++++++++
>  drivers/net/ethernet/intel/ice/ice_ethtool.c  | 10 ++---
>  4 files changed, 63 insertions(+), 5 deletions(-)  create mode 100644 drivers/net/ethernet/intel/ice/ice_ethtool_common.h
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)