netdev - Re: [PATCH net-next v2 2/9] libeth: add common queue stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240829073954.73ef0765@kernel.org>
Date: Thu, 29 Aug 2024 07:39:54 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Alexander Lobakin <aleksander.lobakin@...el.com>
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>, <davem@...emloft.net>,
 <pabeni@...hat.com>, <edumazet@...gle.com>, <netdev@...r.kernel.org>,
 <przemyslaw.kitszel@...el.com>, <joshua.a.hay@...el.com>,
 <michal.kubiak@...el.com>, <nex.sw.ncis.osdt.itp.upstreaming@...el.com>
Subject: Re: [PATCH net-next v2 2/9] libeth: add common queue stats

On Thu, 29 Aug 2024 14:01:06 +0200 Alexander Lobakin wrote:
> > Either way is fine by me. You may want to float the XDP stats first as
> > a smaller series, just extending the spec and exposing from some driver
> > already implementing qstat. In case someone else does object.  
> 
> I think I'll do that the following way. To not delay this series and XDP
> for idpf in general, I'll drop these stats for now, leaving only onstack
> containers (they will be used in libeth_xdp etc.), without the macro
> magic. But at the same time I'll work on extending the NL queue stats,
> incl. XDP ones, and send them separately when they're done. Would that
> be fine?

Modulo implementation details -- SGTM!