netdev - Re: [PATCHv2 net-next] net: ag71xx: update FIFO bits and descriptions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240829201903.GZ1368797@kernel.org>
Date: Thu, 29 Aug 2024 21:19:03 +0100
From: Simon Horman <horms@...nel.org>
To: Rosen Penev <rosenp@...il.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, linux@...linux.org.uk,
	linux-kernel@...r.kernel.org, o.rempel@...gutronix.de,
	p.zabel@...gutronix.de
Subject: Re: [PATCHv2 net-next] net: ag71xx: update FIFO bits and descriptions

On Thu, Aug 29, 2024 at 10:47:01AM -0700, Rosen Penev wrote:
> On Thu, Aug 29, 2024 at 9:52 AM Simon Horman <horms@...nel.org> wrote:
> >
> > On Wed, Aug 28, 2024 at 03:38:47PM -0700, Rosen Penev wrote:
> > > Taken from QCA SDK. No functional difference as same bits get applied.
> > >
> > > Signed-off-by: Rosen Penev <rosenp@...il.com>

...

> > Please consider a patch to allow compilation of this driver with
> > COMPILE_TEST in order to increase build coverage.
> Is that just

Of course we should test that it works, but yes, I think so.

> 
> --- a/drivers/net/ethernet/atheros/Kconfig
> +++ b/drivers/net/ethernet/atheros/Kconfig
> @@ -6,7 +6,7 @@
>  config NET_VENDOR_ATHEROS
>         bool "Atheros devices"
>         default y
> -       depends on (PCI || ATH79)
> +       depends on (PCI || ATH79 || COMPILE_TEST)

FWIIW, I would drop the () while we are here.

>         help
>           If you have a network (Ethernet) card belonging to this class, say Y.
> 
> @@ -19,7 +19,7 @@ if NET_VENDOR_ATHEROS
> 
>  config AG71XX
>         tristate "Atheros AR7XXX/AR9XXX built-in ethernet mac support"
> -       depends on ATH79
> +       depends on ATH79 || COMPILE_TEST
>         select PHYLINK
>         imply NET_SELFTESTS
>         help
> 
> >
> > --
> > pw-bot: cr
>