netdev - RE: [PATCH net-next 1/1] net: dsa: microchip: rename ksz8 series files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <BYAPR11MB3558094BD31FAEE0F5FFE918EC962@BYAPR11MB3558.namprd11.prod.outlook.com>
Date: Thu, 29 Aug 2024 22:51:39 +0000
From: <Tristram.Ha@...rochip.com>
To: <vtpieter@...il.com>
CC: <andrew@...n.ch>, <olteanv@...il.com>, <davem@...emloft.net>,
	<Woojung.Huh@...rochip.com>, <f.fainelli@...il.com>,
	<Arun.Ramadoss@...rochip.com>, <kuba@...nel.org>,
	<UNGLinuxDriver@...rochip.com>, <edumazet@...gle.com>, <pabeni@...hat.com>,
	<pieter.van.trappen@...n.ch>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <o.rempel@...gutronix.de>
Subject: RE: [PATCH net-next 1/1] net: dsa: microchip: rename ksz8 series
 files

> Subject: Re: [PATCH net-next 1/1] net: dsa: microchip: rename ksz8 series files
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content
> is safe
> 
> Hi Arun,
> 
> > Refactoring the file name will better align what the implementation is.
> > But the file header/Kconfig should mentions what all the switches it
> > support.
> > Because there are two switches KSZ8563 and KSZ8567 does not belong to
> > this Family. Instead it belongs to KSZ9477 family with only difference
> > they are not gigabit capable.
> >
> > The switch comes in KSZ8.c files are KSZ8863/KSZ8873,KSZ8895/KSZ8864,
> > KSZ8794/KSZ8795/KSZ8765.
> 
> Thanks, that makes sense - will do so. Looking now at chip_ids there's
> (for me) some confusion regarding KSZ8830 mentions such as
> KSZ8830_CHIP_ID which actually refers to the KSZ8863/73 switches.
> Often, such as in ksz_is_ksz88x3, the KSZ88X3 naming is also used for
> exactly these switches which is more intuitive but it doesn't help to
> have two names for the same thing. Do you agree to remove KSZ8830
> terms  in favor of KSZ88X3 as part of this patch series (will split)?
> 
> PS as far as I can see the KSZ8830 switch itself doesn't exist.

I think the name KSZ8830 was used because the hardware chip id is 0x30.
The switch names are indeed KSZ8863 and KSZ8873.  The switch family can
be called KSZ88X3.

The next switch family is KSZ8895 and KSZ8864.  Then come switch family
KSZ8795/KSZ8794/KSZ8765.

The next generation of switch family is KSZ9897 with many variations and
product names.  KSZ9477 is the switch with all of the features while the
rest have some features and ports disabled.

The KSZ9893/KSZ9563/KSZ8563 switch family shares most of the features of
KSZ9897 but has a slightly different internal design, so it has its own
bugs and issues.

LAN937X is the latest switch family that is based from KSZ9897.

Originally the intention was to have one driver for each switch family,
so there are ksz9477.c and ksz9477_reg.h and ksz8795.c and ksz8795_reg.h.
When KSZ8863 switch support was added the KSZ8863 related code was put in
ksz8795.c as some functions just needed minor changes to support the
switch.  Much later it was decided to have one common DSA driver to
support all KSZ switches, so most new code and register information were
put in ksz_common.c and ksz_common.h.