netdev - Re: [PATCHv4 net-next] net: ag71xx: get reset control using devm api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKxU2N9Lhe7vMpsUgrdpZ7m04-eoT4XA--LRHO0-ssfkPbEyKw@mail.gmail.com>
Date: Wed, 28 Aug 2024 22:56:15 -0700
From: Rosen Penev <rosenp@...il.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, linux@...linux.org.uk, 
	linux-kernel@...r.kernel.org, p.zabel@...gutronix.de
Subject: Re: [PATCHv4 net-next] net: ag71xx: get reset control using devm api

On Wed, Aug 28, 2024 at 9:49 PM Oleksij Rempel <o.rempel@...gutronix.de> wrote:
>
> On Mon, Aug 26, 2024 at 12:28:45PM -0700, Rosen Penev wrote:
> > Currently, the of variant is missing reset_control_put in error paths.
> > The devm variant does not require it.
> >
> > Allows removing mdio_reset from the struct as it is not used outside the
> > function.
> >
> > Signed-off-by: Rosen Penev <rosenp@...il.com>
>
> You forgot to include my Reviewed-by tags from v3
Correct. Although Jakub wants me to respin this removing that always
true branch.
>
> --
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |