netdev - Re: [PATCH net v4] net: phy: Fix missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6655eddc-d203-4430-a938-f4f710220b9b@lunn.ch>
Date: Fri, 30 Aug 2024 16:27:29 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	f.fainelli@...il.com, ansuelsmth@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v4] net: phy: Fix missing of_node_put() for leds

On Fri, Aug 30, 2024 at 10:20:25AM +0800, Jinjie Ruan wrote:
> The call of of_get_child_by_name() will cause refcount incremented
> for leds, if it succeeds, it should call of_node_put() to decrease
> it, fix it.
> 
> Fixes: 01e5b728e9e4 ("net: phy: Add a binding for PHY LEDs")
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>

To be 100% correct, it should have a CC: stable@...r.kernel.org

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#stable-tree

But it will probably be O.K. with it missing.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew