netdev - Re: [PATCH v1] ieee802154: at86rf230: Simplify with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240830160228.GU1368797@kernel.org>
Date: Fri, 30 Aug 2024 17:02:28 +0100
From: Simon Horman <horms@...nel.org>
To: Shen Lichuan <shenlichuan@...o.com>
Cc: alex.aring@...il.com, stefan@...enfreihafen.org,
	miquel.raynal@...tlin.com, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, linux-wpan@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	opensource.kernel@...o.com
Subject: Re: [PATCH v1] ieee802154: at86rf230: Simplify with dev_err_probe()

On Fri, Aug 30, 2024 at 04:14:02PM +0800, Shen Lichuan wrote:
> Use dev_err_probe() to simplify the error path and unify a message
> template.
> 
> Using this helper is totally fine even if err is known to never
> be -EPROBE_DEFER.
> 
> The benefit compared to a normal dev_err() is the standardized format
> of the error code, it being emitted symbolically and the fact that
> the error code is returned which allows more compact error paths.
> 
> Signed-off-by: Shen Lichuan <shenlichuan@...o.com>

...

> @@ -1576,9 +1574,8 @@ static int at86rf230_probe(struct spi_device *spi)
>  
>  	lp->regmap = devm_regmap_init_spi(spi, &at86rf230_regmap_spi_config);
>  	if (IS_ERR(lp->regmap)) {
> -		rc = PTR_ERR(lp->regmap);
> -		dev_err(&spi->dev, "Failed to allocate register map: %d\n",
> -			rc);
> +		dev_err_probe(&spi->dev, PTR_ERR(lp->regmap),
> +			      "Failed to allocate register map\n");
>  		goto free_dev;

After branching to dev_free the function will return rc.
So I think it still needs to be set a in this error path.

-- 
pw-bot: cr