netdev - Re: net/xfrm/xfrm_policy.c:1286:8: error: variable 'dir' is uninitialized when used here [-Werror,-Wuninitialized]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240830164706.GW1368797@kernel.org>
Date: Fri, 30 Aug 2024 17:47:06 +0100
From: Simon Horman <horms@...nel.org>
To: Naresh Kamboju <naresh.kamboju@...aro.org>
Cc: clang-built-linux <llvm@...ts.linux.dev>,
	Netdev <netdev@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>,
	lkft-triage@...ts.linaro.org,
	Linux Regressions <regressions@...ts.linux.dev>,
	Anders Roxell <anders.roxell@...aro.org>,
	Dan Carpenter <dan.carpenter@...aro.org>,
	Arnd Bergmann <arnd@...db.de>,
	Nathan Chancellor <nathan@...nel.org>,
	Nick Desaulniers <ndesaulniers@...gle.com>,
	Florian Westphal <fw@...len.de>,
	Steffen Klassert <steffen.klassert@...unet.com>
Subject: Re: net/xfrm/xfrm_policy.c:1286:8: error: variable 'dir' is
 uninitialized when used here [-Werror,-Wuninitialized]

+ Florian, Steffen

On Fri, Aug 30, 2024 at 12:15:10PM +0530, Naresh Kamboju wrote:
> The x86_64 defconfig builds failed on today's Linux next-20240829
> due to following build warnings / errors.
> 
> Regressions:
> * i386, build
>   - clang-18-defconfig
>   - clang-nightly-defconfig
> 
> * x86_64, build
>   - clang-18-lkftconfig
>   - clang-18-lkftconfig-compat
>   - clang-18-lkftconfig-kcsan
>   - clang-18-lkftconfig-no-kselftest-frag
>   - clang-18-x86_64_defconfig
>   - clang-nightly-lkftconfig
>   - clang-nightly-lkftconfig-kselftest
>   - clang-nightly-x86_64_defconfig
>   - rustclang-nightly-lkftconfig-kselftest
> 
> first seen on next-20240829.
>   Good: next-20240828
>   BAD:  next-20240829
> 
> Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
> 
> build log:
> --------
> net/xfrm/xfrm_policy.c:1286:8: error: variable 'dir' is uninitialized
> when used here [-Werror,-Wuninitialized]
>  1286 |                 if ((dir & XFRM_POLICY_MASK) == XFRM_POLICY_OUT) {
>       |                      ^~~
> net/xfrm/xfrm_policy.c:1257:9: note: initialize the variable 'dir' to
> silence this warning
>  1257 |         int dir;
>       |                ^
>       |                 = 0
> 1 error generated.

I believe that is due to
commit 08c2182cf0b4 ("xfrm: policy: use recently added helper in more places")

I will work on a fix to initialise dir in the loop where it is used.