netdev - Re: [PATCH net-next v3 00/13] net: Simplified with scoped function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bb3adb21-c39d-7873-8eb0-32ba5591adad@huawei.com>
Date: Fri, 30 Aug 2024 10:03:10 +0800
From: Jinjie Ruan <ruanjinjie@...wei.com>
To: Andrew Lunn <andrew@...n.ch>
CC: <woojung.huh@...rochip.com>, <f.fainelli@...il.com>, <olteanv@...il.com>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <linus.walleij@...aro.org>, <alsi@...g-olufsen.dk>,
	<justin.chen@...adcom.com>, <sebastian.hesselbarth@...il.com>,
	<alexandre.torgue@...s.st.com>, <joabreu@...opsys.com>, <wens@...e.org>,
	<jernej.skrabec@...il.com>, <samuel@...lland.org>,
	<mcoquelin.stm32@...il.com>, <hkallweit1@...il.com>, <linux@...linux.org.uk>,
	<ansuelsmth@...il.com>, <UNGLinuxDriver@...rochip.com>,
	<netdev@...r.kernel.org>, <bcm-kernel-feedback-list@...adcom.com>,
	<linux-stm32@...md-mailman.stormreply.com>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-sunxi@...ts.linux.dev>,
	<krzk@...nel.org>, <jic23@...nel.org>
Subject: Re: [PATCH net-next v3 00/13] net: Simplified with scoped function



On 2024/8/29 20:43, Andrew Lunn wrote:
> On Thu, Aug 29, 2024 at 02:31:05PM +0800, Jinjie Ruan wrote:
>> Simplify with scoped for each OF child loop and __free(), as well as
>> dev_err_probe().
> 
> I said the for_each_child_of_node_scoped() parts are fine. The
> __free() parts are ugly, and i would like to reject them. So please
> post just the for_each_child_of_node_scoped() parts for merging, while
> we discuss what to do about __free().

Sure.

> 
>     Andrew
> 
> ---
> pw-bot: cr